Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPO Critic #8

Open
MagMueller opened this issue Feb 15, 2023 · 0 comments
Open

PPO Critic #8

MagMueller opened this issue Feb 15, 2023 · 0 comments

Comments

@MagMueller
Copy link

@leikun-starting Thank you very much!

I have some questions in regard to the critic, maybe from there some improvements arise.

  • Currently the critic only receives the job embedding and not the machine embedding
  • Why are you not updating the critic separately, e.g. with the job_v_loss
    job_v_loss = self.MSE(val[j], rewards_all_env[j])
    currently you simply add the critic loss to the actor loss.
  • The critic is used in both loss functions (job and machine)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant