Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a trait out of PaginationCursor / PaginationCursorData #5275

Open
5 tasks done
dessalines opened this issue Dec 19, 2024 · 0 comments
Open
5 tasks done

Make a trait out of PaginationCursor / PaginationCursorData #5275

dessalines opened this issue Dec 19, 2024 · 0 comments
Labels
area: maintenance enhancement New feature or request

Comments

@dessalines
Copy link
Member

dessalines commented Dec 19, 2024

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
  • Do you agree to follow the rules in our Code of Conduct?

Is your proposal related to a problem?

We currently have a lot of custom PaginationCursors (PostView, all the new Combined endpoints that now use pagination cursors) , with the same after_post and read functions.

Describe the solution you'd like.

This should be made into a trait that each one can implement.

Also, see this comment about making a helper function for ids / prefixes

Describe alternatives you've considered.

NA

Additional context

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: maintenance enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant