Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Changes appears to be empty" ... not. #26

Open
kentfredric opened this issue May 22, 2016 · 2 comments
Open

"Changes appears to be empty" ... not. #26

kentfredric opened this issue May 22, 2016 · 2 comments

Comments

@kentfredric
Copy link
Contributor

Here's a reduced set of a Changes file I think should parse, but completely doesn't, and the error is not exactly enlightening.

0.048
- Asdf
mbtiny dist
# Changes appears to be empty
@kentfredric
Copy link
Contributor Author

According to the logic, it seems to be parsing the structure as

0.048    # BLOCK START
- Asdf    # BLOCK STOP


where it shouldn't be caring that - Asdf is not indented (\S)

Instead, it should be continuing until the next line that starts with a version group, so ^\d

@Leont
Copy link
Owner

Leont commented May 22, 2016

The logic is stolen straight out of dzil's CheckChangesHasContent, the same change should probably be done there.

CPAN::Changes matches against $version::LAX, which may actually be quite sensible too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants