Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots.jl Refactor (goodbye PythonPlot) #114

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Plots.jl Refactor (goodbye PythonPlot) #114

wants to merge 21 commits into from

Conversation

argonaut22
Copy link
Collaborator

@argonaut22 argonaut22 commented Dec 16, 2024 •
edited
Loading

This PR:

  • surgically excises the metastasized plt usage (so we're not installing a GB of python just to plot)
  • replaces it in all places with plt-like plotter, Plots.jl (see outputs.jl for extensive sample usage)
  • Splits outputs.jl into text_outputs.jl and plot_outputs.jl
  • ensures all of this is tested such that changes to data structure will show a break
  • closes Updating Plotting and Data Functionalities #103. noting that the show_plot/verbosity parameter is reserved for another PR

Note:

  • some TODO's are marked where the originally-intended functionality appears absent. Of note: label_bars() which is now replaced with simple legends in the plot
  • data IO tests are re-instated, broken tests are appropriately marked. some are /still/ commented out since they're dependent on the data struct handling task, but they're marked as TODO
  • there may be a better plotting backend to select that would allow direct copying from VScode/etc. Unclear what that is rn

Sample outputs:
image
image

@argonaut22
removed pythoncall pyplot dependencies, commented out plotting, began…
7e3daf6 
… test of `Plots.jl` using `example_PRD.jl` which has its own issues vav keeping up to date with codebase changes
@argonaut22
airfoil section plotter redone, renamed to avoid namespace conflicts
27bafc8
@argonaut22
refactored show_ff_sens, testing not extensive
156877a
@argonaut22
discovered outputs.jl version of PayloadRange, adjusted
52216bd
@argonaut22
refactored stickfig to use Plots.jl
d785f4a
@argonaut22
properly commenting io tests. will show as broken, some as error "une…
38158c7 
…xpected pass"
@argonaut22
outputs.jl refactored to use Plots.jl 1/
f65d162
@argonaut22
formatting tweaks to mission! and takeoff!
553d22e
@argonaut22
example_opt refactored for Plotsjl. Was broken, still broken, but the…
bd9be3d 
… plotting is up to date
@argonaut22
payload_range.md refactored
70d5dc0
@argonaut22
refactored NM_optimization.md to use Plots.jl; tweak to example_opt.jl
e35347d
@argonaut22
tweak for alias deconflicting
203b467
@argonaut22
PyPlot purge continues, sensitivity.jl refactored for Plots.jl
af70d1c
@argonaut22
outputs.jl using Plots.jl, changed signatures from ax to plot_obj…
b1b3294 
…. 2/
@argonaut22
outputs.jl refactor to use Plots.jl; pythonplot purge appears complet…
6f5979e 
…e. Added Statsplots dependency (for groupedbar functionality)
@argonaut22
added outputs tests; un-broke the passing io tests to avoid errors; t…
805f992 
…idying up + making things consistent. Tests in a passing state
@argonaut22
splitting outputs.jl 1/
4b8c4f1
@argonaut22
outputs.jl split into text_outputs.jl and plot_outputs.jl 2/2
940a368
@argonaut22
adjusted filenames to follow output_*****.jl convention
55e4e7e
@argonaut22
minor corrections, added plot margins
e5b4d40
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.24153% with 107 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (430cfd8) to head (9f766f8).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
src/IO/output_plots.jl 82.54% 92 Missing ⚠️
src/utils/sensitivity.jl 0.00% 8 Missing ⚠️
src/aero/airfoil.jl 0.00% 4 Missing ⚠️
src/mission/odperformance.jl 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   73.41%   78.76%   +5.34%     
==========================================
  Files          77       81       +4     
  Lines       13908    13442     -466     
==========================================
+ Hits        10211    10587     +376     
+ Misses       3697     2855     -842

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@argonaut22 argonaut22 marked this pull request as ready for review December 16, 2024 21:56
aditeyashukla
aditeyashukla reviewed Dec 17, 2024
View reviewed changes
example/example_PRD.jl Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this will have to change with Nico's PR about the payload range/woper updates

aditeyashukla
aditeyashukla reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@aditeyashukla aditeyashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Will need updates once Wing/tail PR and Woper PR are merged
Happy to help for updates regarding the former

ngomezve
ngomezve reviewed Dec 18, 2024
View reviewed changes
src/IO/outputs.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngomezve ngomezve ngomezve left review comments

@aditeyashukla aditeyashukla aditeyashukla left review comments

@askprash askprash Awaiting requested review from askprash

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating Plotting and Data Functionalities
3 participants
@argonaut22 @aditeyashukla @ngomezve