Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nullability checks during data retrieval #23

Open
EitanBlumin opened this issue Apr 18, 2023 · 1 comment · May be fixed by #24
Open

Add missing nullability checks during data retrieval #23

EitanBlumin opened this issue Apr 18, 2023 · 1 comment · May be fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@EitanBlumin
Copy link
Collaborator

Several data retrieval calls could potentially throw an error if the data column is NULL.
A nullability check should be added to avoid this and/or create an informative error message.

if (reply_to.IsNull) reply_to = rdr.GetSqlString(1);

@EitanBlumin
Copy link
Collaborator Author

Hi @twells-fi , please try checking version 2.4 which I committed here:

https://github.com/MadeiraData/sql-clr-ics/blob/v2.4/sql_clr_ics/sql_clr_ics_install.sql

Let me know if it works better for you.

@EitanBlumin EitanBlumin linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant