Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataInspector bounding boxes in meshscatter do not transform correctly with rotations + markersize #3670

Closed
3 tasks done
pablosanjose opened this issue Mar 2, 2024 · 2 comments
Labels
bug interaction anything event related

Comments

@pablosanjose
Copy link
Contributor

pablosanjose commented Mar 2, 2024

  • are you running newest version (version from docs) ? Yes
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie) Yes
  • What platform + GPU are you on? Macbook Pro M1 Max, macos 14.3.1

The bounding boxes of DataInspector do not honor the rotation of markers using meshscatter when a markersize is also used. MWE below:

julia> p = Point{3, Float32}[[0.0, 0.0, 1.0], [0.0, 1.0, 0.0], [1.0, 0.0, 0.0]];

julia> r = Vec{3, Float32}[[0.0, 0.0, 0.2], [0.0, 0.2, 0.0], [0.2, 0.0, 0.0]];

julia> cyl = Makie.GeometryBasics.Cylinder(Point3f(0., 0., -1), Point3f(0., 0, 1), Float32(1));

julia> meshscatter(p, marker = cyl, rotations = r, markersize = Vec{3, Float32}(0.3, 0.3, 0.1))

julia> DataInspector();

Note, in the screenshot, that while red bounding box of the top cylinder is scaled correctly, the others are not (the bounding box is scaled along the z-axis, but not rotated)

Screenshot 2024-03-02 at 18 10 51
Screenshot 2024-03-02 at 18 10 55

@t-bltg t-bltg added the interaction anything event related label Mar 3, 2024
@kbarros
Copy link
Contributor

kbarros commented Mar 9, 2024

See also #3512.

@ffreyer
Copy link
Collaborator

ffreyer commented May 24, 2024

Fixed in Makie 0.21 via #3681

@ffreyer ffreyer closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug interaction anything event related
Projects
None yet
Development

No branches or pull requests

4 participants