Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poly Circle & Rect stroke #4664

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Fix poly Circle & Rect stroke #4664

merged 6 commits into from
Dec 16, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 13, 2024

Description

The breaking pr changed poly(Circle(...)) to use the Circle wireframe for stroke, which this pr fixes.

It also changes (fixes?) Rect2 stroke to be continuous, i.e. avoid corners like this:

image

Also extends a refimg test to test these things

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@ffreyer ffreyer added the skip-changelog Skips changelog enforcer label Dec 13, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Dec 13, 2024

Benchmark Results

SHA: b77303ddb8fc2b991a2fc893fa967a1eba657484

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer
Copy link
Collaborator Author

ffreyer commented Dec 13, 2024

It also changes (fixes?) Rect2 stroke to be continuous, i.e. avoid corners like this:

image

This is causing "poly stroke & array input" and "Axis3 viewmodes, xreversed, aspect, perspectivenes" to fail. This is also a real change from 0.21, so this pr should get a changelog entry

@ffreyer ffreyer removed the skip-changelog Skips changelog enforcer label Dec 13, 2024
@ffreyer ffreyer marked this pull request as ready for review December 14, 2024 00:02
@ffreyer ffreyer merged commit f29e93a into master Dec 16, 2024
22 checks passed
@ffreyer ffreyer deleted the ff/poly-fixes branch December 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants