Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kmer.shred always returns sparse kmer_id/count array #134

Open
MatthewRalston opened this issue Apr 4, 2024 · 2 comments
Open

Kmer.shred always returns sparse kmer_id/count array #134

MatthewRalston opened this issue Apr 4, 2024 · 2 comments
Assignees
@MatthewRalston
Labels
documentation Improvements or additions to documentation
Milestone
V0.7 stable?

Comments

@MatthewRalston
Copy link
Owner

Needs to be documented. Especially because the edge list is now totally sparse.
@MatthewRalston MatthewRalston added the documentation Improvements or additions to documentation label Apr 4, 2024
@MatthewRalston MatthewRalston added this to the V0.7 stable? milestone Apr 4, 2024
@MatthewRalston MatthewRalston self-assigned this Apr 4, 2024
MatthewRalston added a commit that referenced this issue Apr 4, 2024
@MatthewRalston
Pushing the 0.7.9 version bump in code only, may not affect the actua…
493c7fe 
…l release. Doing the appmap schemas in parallel. Addressing issue #132, issue #134, issue #135.
@MatthewRalston
Copy link
Owner Author

But it doesn't?

@MatthewRalston
Copy link
Owner Author

I was backwards. It totally needs documentation. True.

It being the following.

The k-mer utility does not produce a sparse k-mer count array. Specifically said: the nullomers are present in the k-mer array and its length is 4^k. But, the fact that it was/wasn't could/couldn't be sparse, and what state the output is in, needs documentation (Linking #137 to document the k-mer array shape explicitly in the kmerdb profile readme section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewRalston MatthewRalston

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
V0.7 stable?
Development

No branches or pull requests
1 participant
@MatthewRalston