Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header files should have different names #9862

Open
irwir opened this issue Dec 19, 2024 · 1 comment
Open

Header files should have different names #9862

irwir opened this issue Dec 19, 2024 · 1 comment
Labels
bug size-s Estimated task size: small (~2d)

Comments

@irwir
Copy link
Contributor

irwir commented Dec 19, 2024

Suggested enhancement

Add psa_ prefix to the files in /tf-psa-crypto/include/tf-psa-crypto directory (or any other way to make file names distinct).

Justification

Currently there are two sets of files with different contents but the same name: build_info.h and check_config.h in include/mbedtls and /tf-psa-crypto/include/tf-psa-crypto directories.
Now IDE would be showing the same name in tab headers if both build_info.h were opened.

Mbed TLS needs this because of added convenience.
A similar change had been made previously - when config.h was renamed to mbedtls_config.h (the name was found to be too general).

@mpg mpg added the bug label Dec 23, 2024
@mpg mpg added the size-s Estimated task size: small (~2d) label Dec 23, 2024
@mpg mpg moved this to Configuration split in Mbed TLS Epics Dec 23, 2024
@mpg
Copy link
Contributor

mpg commented Dec 23, 2024

Hi @irwir and thanks for this suggestion! Indeed it seems to me that the reasons that led us to rename config.h would also apply here. (IIRC, it was not just about convenience - some people use build systems that simply cannot cope with files with the same name in different directories.)

Cc @ronald-cron-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug size-s Estimated task size: small (~2d)
Projects
Status: Configuration split
Development

No branches or pull requests

2 participants