fix: Ensure tokens are cached when using browser authentication or basic authentication with MFA #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation-caching Fix browser authentication and MFA token caching
edgarrmondragon
changed the title
edgarrmondragon
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix the issue reported here, essentially making sure that oauth tokens are cached when using browser authentication to avoid having multiple browser windows popping in consecutive runs, even when the Snowflake account being accessed has ALLOW_ID_TOKEN option enabled.
While there, also ensured proper caching of MFA tokens (when the user account has ALLOW_CLIENT_MFA_CACHING enabled).
Implementation details:
secure-local-storageextra tosnowflake-connector-pythondependency"client_request_mfa_token": Trueand"client_store_temporary_credential": Trueto the connection arguments of the SQLAlchemy engine. This is mostly relevant for Linux users, as for MacOs (at least) thesecure-local-storageextra is enough.pre-commitsteps)