feat: add configuration to store enums as pg custom domain types #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: more efficient
domain
storage of enum data.JSON Schema References:
Enums are stored as 1 or 2 bytes they are very space efficient when it's possible to use them.
Because enums have a lots of downsides too, this feature is behind a feature flag.
This can never be a full, specification accurate implementation, as a subset of valid jsonschema
enum
cannot map to a valid pgdomain
. Ex:{"enum": ["a", 3, null]}
is a valid jsonschema.