You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Grabbable refers to BaseGrabber in its implementation, which can cause issues if other people want to use their own IGrabNotifiers. It might be a good idea for certain items like GrabBegin to use IGrabNotifier instead, however child classes like PhysicsGrabbable call GetComponent on the hand argument passed in, so using GameObject as the argument for GrabBegin can be a good compromise.
Now one issue with trying to decouple Grabbable from BaseGrabber is that the former does call the static function BaseGrabber.ClearAllGrabs in UnsubscriberGrabber. You might not be able to cleanly replace that specific code with an interface...
The text was updated successfully, but these errors were encountered:
That is a good idea.
Yes initially I tought people would want to provide their own Grabber-Grabbable pair (in my mind they go in hand) but I don't see a reason not to communicate with more generic intentions.
Grabbable refers to BaseGrabber in its implementation, which can cause issues if other people want to use their own IGrabNotifiers. It might be a good idea for certain items like GrabBegin to use IGrabNotifier instead, however child classes like PhysicsGrabbable call GetComponent on the hand argument passed in, so using GameObject as the argument for GrabBegin can be a good compromise.
Now one issue with trying to decouple Grabbable from BaseGrabber is that the former does call the static function BaseGrabber.ClearAllGrabs in UnsubscriberGrabber. You might not be able to cleanly replace that specific code with an interface...
The text was updated successfully, but these errors were encountered: