Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove broken coverage report link #29410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Description

The unit test coverage report was previously available in the metamaskbot comment, but this link has been broken since we migrated unit tests from CircleCI to GitHub Actions in #25570

The broken link has been removed for now. It can be restored in the future, after migrating the metamaskbot comment to GitHub actions as well.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

Check that the broken link is no longer shown in the metamaskbot PR comment.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The unit test coverage report was previously available in the
`metamaskbot` comment, but this link has been broken since we migrated
unit tests from CircleCI to GitHub Actions in #25570

The broken link has been removed for now. It can be restored in the
future, after migrating the `metamaskbot` comment to GitHub actions as
well.
@metamaskbot
Copy link
Collaborator

Builds ready [87f14cc]
Page Load Metrics (1743 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15591975175912560
domContentLoaded14921961171312359
load15011973174312359
domInteractive25253515024
backgroundConnect1084332311
firstReactRender1699573014
getState492202512
initialActions00000
loadScripts11111530128311354
setupStore68012168
uiStartup174325172112247118
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 21:55
@hjetpoluru hjetpoluru self-requested a review December 20, 2024 23:30
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below link for the code coverage does not appear in the PR and the changes implemented in the PR
code coverage: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants