Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button that uses Web3 provider to send transaction #137

Open
danjm opened this issue Nov 22, 2021 · 0 comments
Open

Add button that uses Web3 provider to send transaction #137

danjm opened this issue Nov 22, 2021 · 0 comments

Comments

@danjm
Copy link
Contributor

danjm commented Nov 22, 2021

Currently, the test dapp only uses ethers.js for instantiating a provider. We need to also use web3.js, because many dapps use that exclusively. For us to properly test and QA MetaMask, we should test against the same tools that dapps use. Also, some functionality (e.g. batch transactions) are better supported by web3.js than ethers.

To start, let's just allow the test dapp to use web3 in place of ethers wherever it is currently used

  • add a radio button toggle somewhere on the top of the page. The options in the toggle should be "web3" and "ethers"
  • the toggle should default to ethers
  • if ethers is selected, the create token and deploy contract buttons should behave as they do today
  • if web3 is selected, create token and deploy contract should use web3 instead of the current "factories" created by the ethers provider, however the transactions created by the buttons should be the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants