Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend-Listenansicht Details: Bei leeren Feldern Fehlerhinweis #1318

Closed
ThomasJanotta opened this issue Jul 1, 2019 · 14 comments
Closed

Backend-Listenansicht Details: Bei leeren Feldern Fehlerhinweis #1318

ThomasJanotta opened this issue Jul 1, 2019 · 14 comments
Assignees
@discordier @ThomasJanotta
Labels
backend This seems to be a bug in the backend bug A bug! A bug! Fast, squish it! testing This ticket is reported to be fixed by a developer and should be tested.
Milestone
2.1.5

Comments

@ThomasJanotta
Copy link

ThomasJanotta commented Jul 1, 2019 •
edited
Loading

php 7.2.11/7.3.4
contao 4.4.40
mm core/bundle 2.1.3
via composer
mit mm packages 2.1.x
dcg 2.1.3
(ich habe eine Live- und Testversion, deswegen 2 Konfigs oben)

Wenn man in der Backend-Listenansicht eines MM auf das "blaue i" für Details des Datensatzes klickt, erscheint bei leeren Feldern der Hinweis:

Unexpected behaviour, attribute title text representation was not rendered.

Diese Meldung wird erzeugt durch:
vendor\metamodels\core\src\CoreBundle\EventListener\DcGeneral\ItemRendererListener.php

erroremptyfield
@discordier
Copy link
Member

What attribute type is this? We might have to change the text rendering for that one.

@discordier discordier added bug A bug! A bug! Fast, squish it! question We have a question, please elaborate on the ticket. labels Jul 1, 2019
@ThomasJanotta
Copy link
Author

ThomasJanotta commented Jul 2, 2019 •
edited
Loading

Hi discordier, it affects "all" attribute types

Title : text
Research interest : longtext
Publish Academic background : checkbox
Category (when empty) : select

@zonky2 zonky2 removed the question We have a question, please elaborate on the ticket. label Jul 9, 2019
@zonky2 zonky2 added this to the 2.1.4 milestone Jul 9, 2019
@zonky2 zonky2 added question We have a question, please elaborate on the ticket. and removed bug A bug! A bug! Fast, squish it! labels Jul 9, 2019
@zonky2
Copy link
Contributor

zonky2 commented Jul 9, 2019

@ThomasJanotta können wir nicht nachvollziehen - bei MSC.photo__sort ist das aktuell "normal" - die internal Attribute sollten hier gar nicht erscheinen...

alles aktuell?

screenshot_629

@discordier
Copy link
Member

discordier commented Jul 9, 2019 •
edited
Loading

photo__sort zeigt seit 8f5a455 nun auch nur noch einen Leerstring, entfernen kann ich es leider nicht ohne Eingriff im DCG. Dennoch sollte das Problem des OP nie auftreten.

@zonky2
Copy link
Contributor

zonky2 commented Jul 9, 2019

neues Ticket zum Thema: #1319

ich habe noch diverse Implementierungen durchgesehen, ohne diese Fehlermeldung - ich schließe das Ticket wg. "nicht nachvollziehbar"

@zonky2 zonky2 closed this as completed Jul 9, 2019
@discordier discordier removed this from the 2.1.4 milestone Jul 9, 2019
@discordier discordier added the invalid This issue just does not seem to be right or did not make sense in MetaModels context label Jul 9, 2019
@zonky2 zonky2 mentioned this issue Jul 10, 2019
Open
@zonky2
Copy link
Contributor

zonky2 commented Jul 10, 2019

Fehlermeldung kommt dann, wenn in den Rendereinstellungen die Checkbox "Leere Einträge verbergen" checked ist - siehe #1319 (comment)

@zonky2 zonky2 reopened this Jul 10, 2019
@zonky2 zonky2 removed the invalid This issue just does not seem to be right or did not make sense in MetaModels context label Jul 10, 2019
@zonky2 zonky2 modified the milestones: 2.1.4, 2.1.5 Jul 10, 2019
discordier added a commit that referenced this issue Jul 13, 2019
@discordier
Fix #1318 - allow empty values in "show"
95c53df 
Empty values must be allowed in "show" when "hideEmptyValues" is active.

The empty value checks have now been refactored into a static helper
class as the detection of empty values is not within the attribute
classes and therefore is somewhat bogus.
We should refactor this for 3.0 to have attributes determine their empty
values on their own.
@discordier discordier added backend This seems to be a bug in the backend bug A bug! A bug! Fast, squish it! testing This ticket is reported to be fixed by a developer and should be tested. and removed question We have a question, please elaborate on the ticket. labels Jul 13, 2019
@ThomasJanotta
Copy link
Author

Hallo,
I updated in the CM to 2.1.4, cleared additionally cleared Anwendungs-Cache und Composer-Cache,
but no changes. Something else to update?
error2

@zonky2
Copy link
Contributor

zonky2 commented Jul 13, 2019

fix in 2.1.5 - see 95c53df

try "dev-hotfix/2.1.5 as 2.1"
see https://metamodels.readthedocs.io/de/latest/manual/install.html#test-von-speziellen-paketen

@ThomasJanotta
Copy link
Author

Hmm, - Can only install one of: metamodels/core[2.1.x-dev, dev-hotfix/2.1.5]

@zonky2
Copy link
Contributor

zonky2 commented Jul 13, 2019 •
edited
Loading

try "dev-hotfix/2.1.5 as 2.1.5"

@ThomasJanotta
Copy link
Author

Hallo,
it works. Mit und ohne Checkbox keine 'Fehlermeldung'.

@ThomasJanotta
Copy link
Author

Eine logische Sache noch, Contao macht das zwar auch, aber wenn da steht 'Leere Einträge verbegen' dürfte in der Backend-Info die jeweilige ZEILE ja gar nicht auftauchen, z.B. title'...

@zonky2
Copy link
Contributor

zonky2 commented Jul 14, 2019

da kann man unterschiedlicher Meinung sein - für mich hat die "i-Ausgabe" nichts mit den Rendereinstellungen zu tun und sollte (wie bei Contao) eine Komplettübersicht der Daten widerspiegeln, d.h. für mich sollten an der Stelle immer alle Daten ausgegeben werden.

@zonky2 zonky2 closed this as completed Jul 14, 2019
@ThomasJanotta
Copy link
Author

Agreed ;-)

stefanheimes added a commit that referenced this issue Aug 27, 2019
@stefanheimes
Merge tag '2.1.5'
a85c97c 
Hotfix version 2.1.5

- Fix #1332 - URL generating used the wrong language
- Fix notices in ToolboxFile (fixes #1327)
- Fix autoloader problems for Contao 4.{4,5} in test
- Fix #1321 - Keep port number when it is non standard
- Addendum #1320 - also display plain values as raw
- Fix #1320 - display attribute names raw
- Fix #1318 - allow empty values in "show"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@discordier discordier

@ThomasJanotta ThomasJanotta

Labels
backend This seems to be a bug in the backend bug A bug! A bug! Fast, squish it! testing This ticket is reported to be fixed by a developer and should be tested.
Projects
None yet
Milestone
2.1.5
Development

No branches or pull requests
3 participants
@discordier @zonky2 @ThomasJanotta