Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicExpressions to 0.17, (keep existing compat) #312

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DynamicExpressions package from 0.16 to 0.16, 0.17.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-04-30-00-08-48-249-02861387008 branch from 581adef to 6575f90 Compare April 30, 2024 00:08
@avik-pal
Copy link

avik-pal commented May 9, 2024

@MilesCranmer is anything holding this off?

Copy link
Contributor Author

github-actions bot commented May 9, 2024

Benchmark Results

master 5f830cc... master/5f830ccde30870...
search/multithreading 16.7 ± 0.57 s 18.4 ± 0.39 s 0.908
search/serial 32.7 ± 0.09 s 32.2 ± 0.092 s 1.02
utils/best_of_sample 1.16 ± 0.45 μs 0.862 ± 0.31 μs 1.35
utils/check_constraints_x10 12.2 ± 3.2 μs 12.1 ± 3.1 μs 1
utils/compute_complexity_x10/Float64 2.23 ± 0.11 μs 2.19 ± 0.11 μs 1.02
utils/compute_complexity_x10/Int64 2.19 ± 0.11 μs 2.17 ± 0.11 μs 1.01
utils/compute_complexity_x10/nothing 1.5 ± 0.1 μs 1.5 ± 0.1 μs 1
utils/optimize_constants_x10 30.5 ± 6.6 ms 30.3 ± 6.5 ms 1.01
time_to_load 0.905 ± 0.00028 s 0.921 ± 0.0092 s 0.983

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer
Copy link
Owner

I need to update the module names from eg DynamicExpressions.EquationModule to DynamicExpressions.NodeModule.

The change simply shows up as a deprecation warning as I have made EquationModule an alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants