Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ConstructionBase to 1, (keep existing compat) #357

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ConstructionBase package from <1.5.7 to <1.5.7, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor Author

github-actions bot commented Nov 20, 2024

Benchmark Results

master 85c450e... master/85c450e0b274ab...
search/multithreading 21.5 ± 2.3 s 22.3 ± 0.97 s 0.964
search/serial 32.7 ± 0.12 s 34 ± 0.96 s 0.962
utils/best_of_sample 2.36 ± 1.8 μs 1.96 ± 1.6 μs 1.2
utils/check_constraints_x10 12.1 ± 3.2 μs 12.4 ± 3.4 μs 0.976
utils/compute_complexity_x10/Float64 2.09 ± 0.11 μs 2.1 ± 0.11 μs 0.995
utils/compute_complexity_x10/Int64 2.05 ± 0.11 μs 2.04 ± 0.12 μs 1
utils/compute_complexity_x10/nothing 1.42 ± 0.11 μs 1.49 ± 0.1 μs 0.953
utils/insert_random_op_x10 5.84 ± 1.9 μs 5.93 ± 1.9 μs 0.985
utils/next_generation_x100 0.452 ± 0.13 ms 0.443 ± 0.12 ms 1.02
utils/optimize_constants_x10 0.037 ± 0.0087 s 0.0368 ± 0.0085 s 1
utils/randomly_rotate_tree_x10 5.24 ± 0.58 μs 5.24 ± 0.58 μs 1
time_to_load 1.78 ± 0.013 s 1.82 ± 0.03 s 0.975

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11931119919

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.462%

Totals Coverage Status
Change from base Build 11931099749: 0.0%
Covered Lines: 3113
Relevant Lines: 3261

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 88c4aaf into master Nov 20, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-10-15-00-11-26-498-00928743823 branch November 20, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants