Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for LossFunctions to 1, (keep existing compat) #373

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the LossFunctions package from 0.10, 0.11 to 0.10, 0.11, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@MilesCranmer MilesCranmer force-pushed the compathelper/new_version/2024-11-28-00-12-33-904-01376574195 branch from ff4691f to c5bbfcc Compare November 28, 2024 14:58
Copy link
Contributor Author

Benchmark Results

master c5bbfcc... master/c5bbfcc267fcb6...
search/multithreading 22.1 ± 1.2 s 21.9 ± 0.47 s 1.01
search/serial 33.3 ± 0.28 s 34 ± 0.23 s 0.978
utils/best_of_sample 1.77 ± 1.6 μs 1.93 ± 1.7 μs 0.917
utils/check_constraints_x10 11.9 ± 3.2 μs 12.1 ± 3.2 μs 0.983
utils/compute_complexity_x10/Float64 2.09 ± 0.12 μs 2.11 ± 0.12 μs 0.991
utils/compute_complexity_x10/Int64 2.07 ± 0.12 μs 2.05 ± 0.12 μs 1.01
utils/compute_complexity_x10/nothing 1.4 ± 0.1 μs 1.47 ± 0.13 μs 0.952
utils/insert_random_op_x10 5.89 ± 1.8 μs 5.89 ± 1.8 μs 1
utils/next_generation_x100 0.437 ± 0.11 ms 0.446 ± 0.12 ms 0.98
utils/optimize_constants_x10 0.0387 ± 0.009 s 0.0367 ± 0.0086 s 1.06
utils/randomly_rotate_tree_x10 5.26 ± 0.59 μs 5.29 ± 0.62 μs 0.994
time_to_load 1.79 ± 0.014 s 1.82 ± 0.013 s 0.985

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12071266829

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.47%

Totals Coverage Status
Change from base Build 12071256599: 0.0%
Covered Lines: 3119
Relevant Lines: 3267

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 667df82 into master Nov 28, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-11-28-00-12-33-904-01376574195 branch November 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants