Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of logger in distributed mode #376

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

MilesCranmer
Copy link
Owner

Missing TensorBoardLogger extension import for workers.

Also I added a new feature to specify extensions for importing on workers.

@MilesCranmer MilesCranmer force-pushed the fix-distributed-logging branch from cdecc15 to 788ce37 Compare December 3, 2024 13:57
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Benchmark Results

master 788ce37... master/788ce37f48c910...
search/multithreading 22.2 ± 1.5 s 21.7 ± 1.1 s 1.02
search/serial 33.7 ± 0.21 s 32.5 ± 0.14 s 1.04
utils/best_of_sample 1.9 ± 1.6 μs 1.9 ± 1.7 μs 1
utils/check_constraints_x10 11.3 ± 2.8 μs 11.5 ± 2.9 μs 0.99
utils/compute_complexity_x10/Float64 2.08 ± 0.11 μs 2.11 ± 0.11 μs 0.986
utils/compute_complexity_x10/Int64 2.06 ± 0.11 μs 2.02 ± 0.1 μs 1.02
utils/compute_complexity_x10/nothing 1.42 ± 0.1 μs 1.46 ± 0.11 μs 0.973
utils/insert_random_op_x10 5.96 ± 1.8 μs 5.91 ± 1.9 μs 1.01
utils/next_generation_x100 0.441 ± 0.07 ms 0.444 ± 0.12 ms 0.992
utils/optimize_constants_x10 0.0361 ± 0.0085 s 0.0365 ± 0.0084 s 0.99
utils/randomly_rotate_tree_x10 5.36 ± 0.62 μs 5.34 ± 0.62 μs 1
time_to_load 1.88 ± 0.0086 s 1.87 ± 0.022 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12141179326

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.503%

Totals Coverage Status
Change from base Build 12109819333: 0.03%
Covered Lines: 3122
Relevant Lines: 3269

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 36acbc3 into master Dec 3, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the fix-distributed-logging branch December 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants