Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce allocations from type assertion #385

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

MilesCranmer
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Benchmark Results

master 652ea0b... master/652ea0b7330e17...
search/multithreading 22.4 ± 1.9 s 16.6 ± 0.59 s 1.35
search/serial 34.5 ± 1.5 s 29.2 ± 0.22 s 1.18
utils/best_of_sample 1.94 ± 1.5 μs 1.84 ± 1.4 μs 1.05
utils/check_constraints_x10 11.4 ± 2.9 μs 11.3 ± 2.9 μs 1.01
utils/compute_complexity_x10/Float64 2.08 ± 0.11 μs 2.08 ± 0.11 μs 1
utils/compute_complexity_x10/Int64 2.06 ± 0.12 μs 2.06 ± 0.14 μs 1
utils/compute_complexity_x10/nothing 1.46 ± 0.1 μs 1.45 ± 0.12 μs 1.01
utils/insert_random_op_x10 5.81 ± 1.9 μs 5.81 ± 1.8 μs 1
utils/next_generation_x100 0.371 ± 0.12 ms 0.421 ± 0.1 ms 0.882
utils/optimize_constants_x10 0.038 ± 0.0089 s 0.0354 ± 0.0075 s 1.08
utils/randomly_rotate_tree_x10 5.22 ± 0.59 μs 5.34 ± 0.59 μs 0.978
time_to_load 1.9 ± 0.032 s 1.88 ± 0.02 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer
Copy link
Owner Author

Error looks to just be an ambiguity. I’ll update the TemplateExpression trait to be more generic

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12270167912

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 95.163%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/TemplateExpression.jl 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/InterfaceDynamicExpressions.jl 2 97.33%
Totals Coverage Status
Change from base Build 12241096420: -0.06%
Covered Lines: 3128
Relevant Lines: 3287

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 5714142 into master Dec 11, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the reduce-allocs branch December 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants