Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicExpressions to 1.9, (keep existing compat) #391

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DynamicExpressions package from ~1.8 to ~1.8, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor Author

Benchmark Results

master f7c2cfb... master/f7c2cfbf330b54...
search/multithreading 17.1 ± 1.3 s 17.9 ± 1.1 s 0.96
search/serial 28.3 ± 0.3 s 28.6 ± 0.18 s 0.989
utils/best_of_sample 1.84 ± 1.4 μs 1.64 ± 0.38 μs 1.12
utils/check_constraints_x10 11.2 ± 2.9 μs 11 ± 2.8 μs 1.01
utils/compute_complexity_x10/Float64 2.08 ± 0.12 μs 2.06 ± 0.12 μs 1.01
utils/compute_complexity_x10/Int64 2.05 ± 0.13 μs 2.03 ± 0.11 μs 1.01
utils/compute_complexity_x10/nothing 1.42 ± 0.12 μs 1.44 ± 0.13 μs 0.987
utils/insert_random_op_x10 5.82 ± 1.9 μs 5.92 ± 1.9 μs 0.983
utils/next_generation_x100 0.424 ± 0.099 ms 0.355 ± 0.086 ms 1.2
utils/optimize_constants_x10 0.034 ± 0.0081 s 0.0333 ± 0.0078 s 1.02
utils/randomly_rotate_tree_x10 5.36 ± 0.62 μs 5.21 ± 0.58 μs 1.03
time_to_load 1.85 ± 0.0098 s 1.83 ± 0.014 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12440642187

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 94.754%

Totals Coverage Status
Change from base Build 12342023114: 0.03%
Covered Lines: 3143
Relevant Lines: 3317

💛 - Coveralls

@MilesCranmer MilesCranmer changed the title CompatHelper: bump compat for DynamicExpressions to 1, (keep existing compat) CompatHelper: bump compat for DynamicExpressions to 1.9, (keep existing compat) Dec 21, 2024
@MilesCranmer MilesCranmer merged commit 1c64682 into master Dec 21, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-12-21-00-11-15-516-00336488746 branch December 21, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants