You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You can see two issues with it in the AxisAlignedBB.grow method:
AxisAlignedBB grow(DD;) (obf c) maybe wrong, return dont match | setMinZ(double)
It incorrectly matches it with setMinZ, because it doesn't parse the parameters for grow correctly. Not only does it cut off the last D (because the signature is double, double, double) but it doesn't parse the primitive types at all because it's not split by a ;.
I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.
The text was updated successfully, but these errors were encountered:
I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.
Its a fucking mess, lmao
I have plans to completely rework all of this, do it on server, properly utilize the cadix suit of libs to properly merge spigot and mojang (and others 👀), improving both performance, maintainability and most importantly, precision, but I also wanna work on so many other projects, that I didn't have the time to put much work into it yet.
I do think that any work put into the old "parser", is a waste of time.
You can see two issues with it in the AxisAlignedBB.grow method:
It incorrectly matches it with setMinZ, because it doesn't parse the parameters for grow correctly. Not only does it cut off the last D (because the signature is
double, double, double
) but it doesn't parse the primitive types at all because it's not split by a;
.I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.
The text was updated successfully, but these errors were encountered: