Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Spigot's primitive parameters correctly #89

Open
PaulBGD opened this issue Mar 5, 2021 · 2 comments
Open

Parse Spigot's primitive parameters correctly #89

PaulBGD opened this issue Mar 5, 2021 · 2 comments

Comments

@PaulBGD
Copy link

PaulBGD commented Mar 5, 2021

You can see two issues with it in the AxisAlignedBB.grow method:

AxisAlignedBB      grow(DD;) (obf c) maybe wrong, return dont match        |        setMinZ(double)

It incorrectly matches it with setMinZ, because it doesn't parse the parameters for grow correctly. Not only does it cut off the last D (because the signature is double, double, double) but it doesn't parse the primitive types at all because it's not split by a ;.

I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.

@MiniDigger
Copy link
Owner

I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.

Its a fucking mess, lmao

I have plans to completely rework all of this, do it on server, properly utilize the cadix suit of libs to properly merge spigot and mojang (and others 👀), improving both performance, maintainability and most importantly, precision, but I also wanna work on so many other projects, that I didn't have the time to put much work into it yet.

I do think that any work put into the old "parser", is a waste of time.

@MiniDigger
Copy link
Owner

MiniDigger commented Mar 6, 2021

works
https://i.imgur.com/Pe6GzZ3.png
https://i.imgur.com/VmNuCbt.png
https://i.imgur.com/8sGVUel.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants