Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri-dockerd does not set Resources to ContainerStatus #406

Open
esotsal opened this issue Oct 17, 2024 · 1 comment
Open

cri-dockerd does not set Resources to ContainerStatus #406

esotsal opened this issue Oct 17, 2024 · 1 comment

Comments

@esotsal
Copy link

esotsal commented Oct 17, 2024

cri-dockerd does not set Resources to ContainerStatus code

For comparison containerd sets it code

This results to K8s failure to throttle pod so that it follows resized CPU limit on minikube when cri-dockerd is used.

InPlacePodVerticalScaling in K8s is soon going to reach Beta and luck of such support from cri-dockerd means that end users will face this limitation as described kubernetes/kubernetes#118371 in minikube if cri-dockerd is used.

@afbjorklund
Copy link
Contributor

As far as I know, having Docker support was not a blocker for KEP-1287

As of Kubernetes v1.20, the CRI has included support for in-place resizing of containers via the UpdateContainerResources API, which is implemented by both containerd and CRI-O

So I am not sure that the feature will ever be implemented for Docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants