chore[pipeline]: unify QA GitHub actions in one workflow #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-683-4nxu8zda.web.app |
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-683-tg4takkg.web.app |
davidgamez
commented
Sep 9, 2024
Comment on lines
-27
to
-35
| integration-tests: | ||
| uses: ./.github/workflows/integration-tests.yml | ||
| needs: | ||
| - api-build-deployment | ||
| with: | ||
| API_URL: 'https://api-qa.mobilitydatabase.org' | ||
| secrets: | ||
| REFRESH_TOKEN: ${{ secrets.QA_API_TEST_REFRESH_TOKEN }} | ||
|
|
There was a problem hiding this comment.
Removing the integration test here as the caller workflow will be executing integration tests after API deployment.
jcpitre
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As done for PROD environment, QA releases must be driven by a unique GitHub action. This has couple of advantages over multiple triggers:
Additional changes
Working GitHub action example: https://github.com/MobilityData/mobility-feed-api/actions/runs/10783827753
Expected behavior:
Only one deployment GitHub action is triggered by main push event.
Testing tips:
Manual testing will be done against QA environment running the unified workflow.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything