Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console errors + warning. Numbers animation home. Home style fix #685

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Alessandro100
Copy link
Contributor

Summary:

  • Fixed console.errors / warnings (many of them were due to DOM html element violations)
  • Added number animation on home page
  • Fixed some styling on home page

NOTE:

  1. Looked at adding "open in new tab" to table row in search feeds. Its a little complicated due to element violations while using an a tag. Would have to be re-looked at
  2. Not all console.errors were solved

Expected behavior:

App should work as normal

Testing tips:

See if the numbers animation works on home page + nothing else is broken

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@Alessandro100 Alessandro100 self-assigned this Aug 16, 2024
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-685-aqxojlkn.web.app

@davidgamez davidgamez merged commit 6b62a3c into main Aug 16, 2024
4 checks passed
@davidgamez davidgamez deleted the winning-day branch August 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants