Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added GBFS metrics to UI #721

Merged
merged 15 commits into from
Sep 5, 2024
Merged

feat: added GBFS metrics to UI #721

merged 15 commits into from
Sep 5, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Aug 29, 2024

Summary:

This PR introduces a new UI for GBFS metrics and includes a small fix to the GBFS validation pipeline, along with modifications to the backend for preprocessed GBFS analytics.

Expected Behavior:

  • Added views for GBFS feeds, GBFS notices, and GBFS versions.
  • Large tables for GBFS and GTFS feeds now use virtualization for improved UX, especially when filtering.
  • Added export to CSV functionality for both GTFS and GBFS feed tables.

Testing Instructions:

  • Use the provided preview URL.
  • Log in with your mobilitydata.org email.
  • Verify the new pages and functionalities.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-721-g3ub5lrt.web.app

@cka-y cka-y linked an issue Aug 29, 2024 that may be closed by this pull request
@cka-y cka-y marked this pull request as ready for review September 5, 2024 14:37
@cka-y cka-y requested a review from Alessandro100 September 5, 2024 14:47
@cka-y cka-y changed the title Feat/714 feat: added GBFS metrics to UI Sep 5, 2024
Comment on lines +149 to +151
isLoading: loading,
showSkeletons: loading,
showProgressBars: loading,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

<Brush
dataKey='date'
height={30}
stroke={theme.palette.primary.main}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff, looks like a good extension from the first PR! LGTM ✅

@cka-y cka-y merged commit 54fd390 into main Sep 5, 2024
6 checks passed
@cka-y cka-y deleted the feat/714 branch September 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics UI - GBFS
2 participants