-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added GBFS metrics to UI #721
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-721-g3ub5lrt.web.app |
isLoading: loading, | ||
showSkeletons: loading, | ||
showProgressBars: loading, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
<Brush | ||
dataKey='date' | ||
height={30} | ||
stroke={theme.palette.primary.main} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff, looks like a good extension from the first PR! LGTM ✅
Summary:
This PR introduces a new UI for GBFS metrics and includes a small fix to the GBFS validation pipeline, along with modifications to the backend for preprocessed GBFS analytics.
Expected Behavior:
Testing Instructions:
mobilitydata.org
email.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything