Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: style and functional add feed form page 1 and 3 #722

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

Alessandro100
Copy link
Contributor

closes #554
Summary:

This PR adds the conditional functionality for the Add Feed Form page 1 and 3 as well as the styling. Once this PR gets the stamp of approval from @emmambd a follow up ticket for translations and unit tests will be made

Expected behavior:

Conditional functionality

Page 1

  • If official producer, there should be a third element in the stepper
  • If gtfs_rt then there should be no feeds link or old feeds link
  • If gtfs and updating link, old feed link required

Page 3

  • If asking for interview, contact email required

Testing tips:

Go to /contribute and play around with the add feed form page 1 and 3 in particular

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
    Screenshot 2024-08-29 at 14 43 27
    Screenshot 2024-08-29 at 14 43 37
    Screenshot 2024-08-29 at 14 43 46
    Screenshot 2024-08-29 at 14 43 54
    Screenshot 2024-08-29 at 14 44 23
    Screenshot 2024-08-29 at 14 44 35

@Alessandro100 Alessandro100 requested a review from emmambd August 29, 2024 18:55
@Alessandro100 Alessandro100 self-assigned this Aug 29, 2024
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-722-x9wpfuec.web.app

@emmambd
Copy link
Contributor

emmambd commented Aug 30, 2024

Looks like there's some stray text on the Add or Update Feed page before login:

Screenshot 2024-08-30 at 12 48 17 PM

I also realized that the "Is authentication required" question should be a part of the first page if "GTFS Schedule is checked", since it affects form validation as defined in the Page 2 requirements of #554

The update feed question looks like it's still on Page 1 for realtime.

@Alessandro100 Alessandro100 force-pushed the feat/554-add-feed-form-1-3 branch from e927d57 to 0ad6198 Compare September 3, 2024 17:32
@emmambd
Copy link
Contributor

emmambd commented Sep 3, 2024

LGTM!

Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alessandro100 Alessandro100 merged commit abe9be0 into main Sep 4, 2024
4 checks passed
@Alessandro100 Alessandro100 deleted the feat/554-add-feed-form-1-3 branch September 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional add a feed form functionality: Page 1 and 3
3 participants