Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null protection for locations field #800

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: add null protection for locations field #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-app/src/app/services/feeds/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export type AllDatasetType =
| undefined;

export function getLocationName(
locations: EntityLocations | undefined,
locations: EntityLocations | undefined | null,
): string {
if (locations === undefined) {
if (locations === undefined || locations === null) {
Copy link
Contributor

@jcpitre jcpitre Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use locations == null to cover both cases? Why do we use a strict equality operator?
(I know its been closed for a while, but I suspect we'll have similar repairs to do. e.g. this comment)

return '';
}
let displayLocation = '';
Expand Down