Feat: seo improvements #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-803-jxvxzzo8.web.app |
Alessandro100
force-pushed
the
feat/752-seo-improvements
branch
from
17b685e to
8bedabe
Compare
davidgamez
reviewed
Nov 11, 2024
davidgamez
reviewed
Nov 11, 2024
Alessandro100
force-pushed
the
feat/752-seo-improvements
branch
from
8816196 to
60569c2
Compare
davidgamez
reviewed
Nov 11, 2024
| } | ||
| const dataTypeVerbose = | ||
| dataType === 'gtfs' ? t('common:gtfsSchedule') : t('common:gtfsRealtime'); | ||
| return t('detailPageDescription', { formattedName, dataTypeVerbose }); |
emmambd
approved these changes
Nov 11, 2024
davidgamez
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #752
Summary:
Most impactful SEO changes listed below and why
Header Elements
Very important to have
h1tags on each page, it lets google (and other search engines) know what the main focus of the page isPage title / description
Distinct page titles help determine what the content of the page is. This helps a lot of unique pages like feed details. Learned that most search engines only check the first 60 characters and after that it gets cut off. It's important to start with the unique elements of the page and end with
- Mobility Databasewhich is less unique to the feed page. Used sites like: Airbnb, Etsy, transitfeeds as referenceTable anchors
Big change. Our table didn't have
atags so google couldn't crawl our feed pages. By turning the table rows intoatags, google knows to visit these pages and index them. This forced to re-think how the+ 2transit providers work. We are also pushing the boundaries of using a table element and should be revisited in the future. Now the table is more accessible and can be tabbed throughWhats next?
This PR implemented the low effort / high reward SEO elements but there are a few more things that could have high impact but more effort
/feeds/mdb-310to/feeds/capital-transit/mdb-310for better seo indexingExpected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Testing tips:
Go through the application and make sure everything looks good. Play with the feeds table. Functionality of the application shouldn't change
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything+2 is now a tool tip
Feeds Performance (NOTE: localhost kills a little performance, should be around 67)
Feed Performance
