Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with default setting, success as a workaround #10

Open
ghost opened this issue Sep 28, 2020 · 1 comment
Open

Issue with default setting, success as a workaround #10

ghost opened this issue Sep 28, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 28, 2020

Hi,

No PDF Download 1.0.6 / Firefox 81.0 (x64) / Windows 7 (x64)

The extension's description on its AMO page states
Please make sure that the setting under Firefox > Preferences > Applications > PDF is set to "Preview in Firefox" in order for this addon to work.

As such (PDF is set to "Preview in Firefox") I've encountered one issue, one only, when attempting to download a PDF from Print Friendly which, once asked to download the PDF, displays its Firefox Preview in Print Friendly's very Download your PDF box:

0

Once clicked:

1

That's for the issue, but when used as a workaround for a Firefox PDF problem I consider as a bug, no-pdf-download brings the solution. Let me explain.

I've always used Preview in Firefox for PDF files. Recently I decided to view PDF files right into my Windows default application (which happens to be Sumatra PDF).
So instead of setting Applications > PDF with Preview in Firefox I've set it with Windows default application. OK.
This works fine as long as files are instructed (by the Website) to be displayed, but once a PDF is instructed to be saved, then it is saved BUT Firefox, in its Applications > PDF changes Windows default application to Always ask which it doesn't do when the setting is Preview in Firefox which is why I assume this to be a Firefox bug.

Now, with no-pdf-download, all is fine. I can use Applications > PDF with Windows default application and PDF are always displayed with Sumatra. From Sumatra I'll use ctrl-s to save the PDF id applicable.

This is why I've written this post, to point out my odd and marvelous experience!

Thanks for the only extension I've found that is able to counter a Firefox PDF handling bug.

@MorbZ
Copy link
Owner

MorbZ commented Sep 28, 2020

The problem you encountered apparently comes from a pdf link which is embedded in an iframe,
in these cases the pdf might appear very small depending on the site.

I may add on option to disable showing pdfs in iframes or open in a new window when I find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant