Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle sending recursive inventories #110

Open
Muqsit opened this issue Dec 4, 2020 · 0 comments
Open

Better handle sending recursive inventories #110

Muqsit opened this issue Dec 4, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Muqsit
Copy link
Owner

Muqsit commented Dec 4, 2020

The NetworkStackLatencyPacket method isn't any better than delayed tasks as it has a high rate of failure for low-latency users. A more reliable method would be one that:

  • Doesn't rely on client-side latency
  • Doesn't rely on server-side delay (such as TaskScheduler::scheduleTask and PlayerNetwork::waitUntil)

Possible solution: Client sends ContainerClosePacket back after server sends one. Perhaps server could queue next InvMenu::send request until then.

@Muqsit Muqsit added enhancement New feature or request help wanted Extra attention is needed labels Dec 4, 2020
@Muqsit Muqsit changed the title Better handle recursive inventory sending Better handle sending recursive inventories Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant