Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeqN Add activate and load to immediate_commands #1527

Open
goetzrrGit opened this issue Oct 29, 2024 · 4 comments
Open

SeqN Add activate and load to immediate_commands #1527

goetzrrGit opened this issue Oct 29, 2024 · 4 comments
Assignees
Labels
clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain

Comments

@goetzrrGit
Copy link
Contributor

Allow activate and load to be used in the @immediate section of a seqN, enabling the generation of 'immediate_activate' and 'immediate_load' in the SeqJson defined by this ticket: NASA-AMMOS/seq-json-schema#25. This would result in the following syntax:

@immediate
load('seq_name')
activate('seq_name')
@goetzrrGit goetzrrGit added the sequencing Anything related to the sequencing domain label Oct 29, 2024
@goetzrrGit goetzrrGit self-assigned this Oct 29, 2024
@goetzrrGit goetzrrGit added this to Aerie Oct 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in Aerie Oct 29, 2024
@goetzrrGit goetzrrGit added the clipper Requests from the Europa Clipper project label Oct 29, 2024
@dandelany dandelany moved this from Todo to In Progress in Aerie Oct 31, 2024
@dandelany
Copy link
Collaborator

dandelany commented Oct 31, 2024

There is a PR for this in the schema repo here: NASA-AMMOS/seq-json-schema#26

Todo list for release:

  • merge schema PR
  • publish latest schema version to npm/pip registries
  • Update jpl_sequence to support new version - @cartermak
  • Update aerie-ui to support new version
    • change seq-json-schema version in package.json
    • update SeqN grammar
  • Update aerie backend to support new version
    • change seq-json-schema version in package.json of sequencing server
    • other changes needed in EDSL/sequencing server?
  • Include in (Aerie) release notes

@cartermak
Copy link
Member

Re: jpl-sequence, that shouldn't be a blocker to this feature.

@dandelany
Copy link
Collaborator

Per discussion with @goetzrrGit - this required a bit more schema change which resets the checklist above. Draft PR here:

NASA-AMMOS/seq-json-schema#29

@dandelany
Copy link
Collaborator

Aerie PRs are ready for review for this:
backend: NASA-AMMOS/aerie#1600
frontend: #1543

@dandelany dandelany moved this from In Progress to In Review in Aerie Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain
Projects
Status: In Review
Development

No branches or pull requests

3 participants