Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth updating default norm arg of intermediate layer features to be consistent with DINOv2? #87

Open
Nik-V9 opened this issue Sep 8, 2024 · 0 comments

Comments

@Nik-V9
Copy link

Nik-V9 commented Sep 8, 2024

Hi, I just wanted to flag this in case you want to make it consistent with DINOv2's encoder.

I see that based on timm, you set the default flag for the norm of intermediate layers to False here:

norm: bool = False,

However, DINOv2's intermediate feature return function uses norm=True as default param: https://github.com/facebookresearch/dinov2/blob/e1277af2ba9496fbadf7aec6eba56e8d882d1e35/dinov2/models/vision_transformer.py#L304

Feel free to close this issue if you think the intended behavior is to use unnormalized intermediate layer features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant