We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I just wanted to flag this in case you want to make it consistent with DINOv2's encoder.
I see that based on timm, you set the default flag for the norm of intermediate layers to False here:
timm
RADIO/radio/radio_model.py
Line 172 in 41ec552
However, DINOv2's intermediate feature return function uses norm=True as default param: https://github.com/facebookresearch/dinov2/blob/e1277af2ba9496fbadf7aec6eba56e8d882d1e35/dinov2/models/vision_transformer.py#L304
norm=True
Feel free to close this issue if you think the intended behavior is to use unnormalized intermediate layer features.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi, I just wanted to flag this in case you want to make it consistent with DINOv2's encoder.
I see that based on
timm
, you set the default flag for the norm of intermediate layers to False here:RADIO/radio/radio_model.py
Line 172 in 41ec552
However, DINOv2's intermediate feature return function uses
norm=True
as default param: https://github.com/facebookresearch/dinov2/blob/e1277af2ba9496fbadf7aec6eba56e8d882d1e35/dinov2/models/vision_transformer.py#L304Feel free to close this issue if you think the intended behavior is to use unnormalized intermediate layer features.
The text was updated successfully, but these errors were encountered: