starknet_subscribeTransactionStatus websocket method #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
+ Coverage 74.58% 74.59% +0.01%
==========================================
Files 110 110
Lines 11771 11895 +124
==========================================
+ Hits 8779 8873 +94
- Misses 2317 2335 +18
- Partials 675 687 +12 ☔ View full report in Codecov by Sentry. |
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
2 times, most recently
from
c5eb695 to
abfec15
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
dae4ff2 to
bffd2bf
Compare
weiihann
reviewed
Oct 25, 2024
weiihann
reviewed
Oct 25, 2024
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
0ce1ae2 to
b170da1
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
b170da1 to
b617595
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
4 times, most recently
from
6b842a7 to
e65a8a4
Compare
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
2 times, most recently
from
bd4e154 to
a552376
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
a552376 to
5150b5f
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
4 times, most recently
from
713b244 to
2d073dd
Compare
IronGauntlets
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
2d073dd to
20c0587
Compare
Co-authored-by: IronGauntlets <[email protected]>
IronGauntlets
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
4b94556 to
62526ce
Compare
IronGauntlets
approved these changes
Jan 3, 2025
|
I have approved the pr because 2 people worked on it, therefore we only need one more approval. |
weiihann
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2209
Comments:
utils/check.go(Add IsNil() #2340)I renamed
utils/check.gotoutils/nil.gobecause of this suggestion