Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression checks in benchmark CI #338

Closed
agostbiro opened this issue Mar 20, 2024 · 0 comments · Fixed by NomicFoundation/hardhat#5037
Closed

Fix regression checks in benchmark CI #338

agostbiro opened this issue Mar 20, 2024 · 0 comments · Fixed by NomicFoundation/hardhat#5037
Assignees
@agostbiro
Milestone
EDR v0.3.3

Comments

@agostbiro
Copy link
Member

Snapshot tests in benchmark CI were disabled in NomicFoundation/hardhat#5008 as they proved to be unreliable.

Definition of Done

Snapshot tests are enabled for benchmark regression checks in the CI and work reliably.
@agostbiro agostbiro self-assigned this Mar 20, 2024
@agostbiro agostbiro added this to EDR Mar 20, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Mar 20, 2024
@agostbiro agostbiro moved this from Unconfirmed to Todo in EDR Mar 20, 2024
@agostbiro agostbiro mentioned this issue Mar 20, 2024
Merged
@agostbiro agostbiro moved this from Todo to In Progress in EDR Mar 25, 2024
@agostbiro agostbiro mentioned this issue Mar 25, 2024
Closed
7 tasks
@agostbiro agostbiro linked a pull request Mar 27, 2024 that will close this issue
ci: enable snapshot testing NomicFoundation/hardhat#5037
Merged
@agostbiro agostbiro moved this from In Progress to Under Review in EDR Mar 27, 2024
@github-project-automation github-project-automation bot moved this from Under Review to Done in EDR Mar 28, 2024
@Wodann Wodann added this to the EDR v0.3.3 milestone Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agostbiro agostbiro

Labels
None yet
Projects
EDR
Status: Done
Milestone
EDR v0.3.3
Development

Successfully merging a pull request may close this issue.

ci: enable snapshot testing NomicFoundation/hardhat
2 participants
@agostbiro @Wodann