Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProviderConfig to Use Uint8Array Instead of Buffer for coinbase #746

Open
schaable opened this issue Dec 12, 2024 · 2 comments
Open
Assignees

Comments

@schaable
Copy link
Member

schaable commented Dec 12, 2024

This is not a high-priority change, but in the ideal scenario, the coinbase field of the ProviderConfig interface would accept a Uint8Array instead of a Buffer.

The motivation is to move away from Node.js-specific types, such as Buffer, to facilitate supporting other runtimes in the future. Currently, Hardhat is casting from Uint8Array to Buffer when passing the coinbase to EDR.

Work should be done in the feat/multichain branch.

@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 12, 2024
@IftequarIffu
Copy link

Hey @schaable, should the work be done on feat/multichain branch?

@Wodann Wodann moved this from Unconfirmed to Todo in EDR Dec 16, 2024
@Wodann
Copy link
Member

Wodann commented Dec 16, 2024

Yes, ideally it would be. I updated the issue description to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants