Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression causing all contracts to be uploaded during verification #4431

Closed
hexpaydaydev opened this issue Oct 1, 2023 · 2 comments
Closed
Assignees

Comments

@hexpaydaydev
Copy link

Version of Hardhat

2.17.2

What happened?

all contracts, whether or not they were linked to targeted contract, were uploaded to etherscan + blockscout

examples:

https://scan.pulsechain.com/address/0x209b1C66cB0Ea99DC2d4Ad13C35859DD1c258988/contracts#address-tabs

https://etherscan.io/address/0x209b1C66cB0Ea99DC2d4Ad13C35859DD1c258988#code

see: contracts/test/IMulticall.sol as an example

Minimal reproduction steps

  1. create a hardhat repo
  2. create 2, unlinked contracts
  3. compile
  4. deploy
  5. verify
  6. check

Search terms

No response

@hexpaydaydev
Copy link
Author

similar to #804

@fvictorio fvictorio assigned schaable and unassigned fvictorio Oct 4, 2023
@fvictorio fvictorio moved this from Ready to To-do in Hardhat Oct 4, 2023
@fvictorio fvictorio changed the title regression causing all contracts to be uploaded regression causing all contracts to be uploaded during verification Oct 19, 2023
@fvictorio
Copy link
Member

Hi @hexpaydaydev, I did exactly what you said (I created a project with two unrelated contracts and deployed and verified one of them) and only one of the files was verified, which is the expected behavior.

I'm tentatively closing this, but I'm happy to re-open it if you can provide a minimal reproducible example

@fvictorio fvictorio closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@github-project-automation github-project-automation bot moved this from To-do to Done in Hardhat Oct 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

3 participants