Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use latest version of chai in docs/sample projects #4733

Closed
fvictorio opened this issue Jan 5, 2024 · 2 comments
Closed

Don't use latest version of chai in docs/sample projects #4733

fvictorio opened this issue Jan 5, 2024 · 2 comments
Assignees
@fvictorio
Labels
status:ready This issue is ready to be worked on type:docs Documentation-related issue

Comments

@fvictorio
Copy link
Member

See comment here.

We should use chai@4 in every snippet in the docs that shows how to install chai, and make sure that the sample projects don't use the latest version (I'm pretty sure they don't but just in case).
@fvictorio fvictorio added the type:docs Documentation-related issue label Jan 5, 2024
@fvictorio fvictorio added this to Hardhat Jan 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 5, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 5, 2024
@fvictorio fvictorio moved this from Backlog to To-do in Hardhat Jan 5, 2024
@lilpolymath
Copy link
Contributor

@fvictorio i would like to work on this.

@lilpolymath lilpolymath mentioned this issue Jan 12, 2024
Merged
3 tasks
@fvictorio fvictorio self-assigned this Jan 25, 2024
@lilpolymath
Copy link
Contributor

@fvictorio you can close this.

@schaable schaable closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from To-do to Done in Hardhat Feb 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fvictorio fvictorio

Labels
status:ready This issue is ready to be worked on type:docs Documentation-related issue
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvictorio @schaable @lilpolymath