Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeTokenBalance should check that balanceOf has the right signature #4794

Open
fvictorio opened this issue Jan 26, 2024 · 0 comments
Open
Labels

Comments

@fvictorio
Copy link
Member

See #4735

While the docs specify that these helpers only work with ERC20 token, the error you get if you use them with an ERC1155 token are very confusing. This is easy to improve on our side: we should add a check that contract.balanceOf.fragment.inputs has only one element of type uint256, or throw an error otherwise.

@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 26, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant