Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose hardhat-ledger api to allow down stream plugins to control UI #4844

Closed
kanej opened this issue Feb 9, 2024 · 0 comments · Fixed by #4946
Closed

Expose hardhat-ledger api to allow down stream plugins to control UI #4844

kanej opened this issue Feb 9, 2024 · 0 comments · Fixed by #4946
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Feb 9, 2024

Ignition clashes with the @nomicfoundation/hardhat-ledger plugin in that both manipulate the cli UI.

The goal is to support a command line deploy from Ignition using a ledger, without clashing UI displays (Ignition rewrites the terminal).

Potential Approach

Based on a quick look over the hardhat-ledger package, the UI manipulating elements come from a wrapper withSpinners. The ledger provider at the heart of the package acts as an event emitter, which withSpinner attaches to.

If withSpinners could be optionally disabled if operating within the context of an Ignition deploy run, and Ignition can hook into the events of the provider, then Ignition can fully control the UI display of the deploy while also customising for ledger interactions.

Open questions then are:

  • How do we model "running in an Ignition deploy context" so that withSpinners can be disabled only in that situation?
  • Can Ignition determine that it is dealing with a ledger provider (and should alter its UI behaviour appropriately)?
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 9, 2024
@fvictorio fvictorio added this to Hardhat Feb 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Feb 9, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Feb 9, 2024
@schaable schaable self-assigned this Feb 14, 2024
@schaable schaable moved this from To-do to In Progress in Hardhat Feb 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants