You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ignition clashes with the @nomicfoundation/hardhat-ledger plugin in that both manipulate the cli UI.
The goal is to support a command line deploy from Ignition using a ledger, without clashing UI displays (Ignition rewrites the terminal).
Potential Approach
Based on a quick look over the hardhat-ledger package, the UI manipulating elements come from a wrapper withSpinners. The ledger provider at the heart of the package acts as an event emitter, which withSpinner attaches to.
If withSpinners could be optionally disabled if operating within the context of an Ignition deploy run, and Ignition can hook into the events of the provider, then Ignition can fully control the UI display of the deploy while also customising for ledger interactions.
Open questions then are:
How do we model "running in an Ignition deploy context" so that withSpinners can be disabled only in that situation?
Can Ignition determine that it is dealing with a ledger provider (and should alter its UI behaviour appropriately)?
The text was updated successfully, but these errors were encountered:
Ignition clashes with the
@nomicfoundation/hardhat-ledger
plugin in that both manipulate the cli UI.The goal is to support a command line deploy from Ignition using a ledger, without clashing UI displays (Ignition rewrites the terminal).
Potential Approach
Based on a quick look over the
hardhat-ledger
package, the UI manipulating elements come from a wrapperwithSpinners
. The ledger provider at the heart of the package acts as an event emitter, whichwithSpinner
attaches to.If
withSpinners
could be optionally disabled if operating within the context of an Ignition deploy run, and Ignition can hook into the events of the provider, then Ignition can fully control the UI display of the deploy while also customising for ledger interactions.Open questions then are:
withSpinners
can be disabled only in that situation?The text was updated successfully, but these errors were encountered: