Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform code style check in CI pipeline #6

Open
pelesh opened this issue Mar 31, 2023 · 1 comment
Open

Perform code style check in CI pipeline #6

pelesh opened this issue Mar 31, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request testing

Comments

@pelesh
Copy link
Collaborator

pelesh commented Mar 31, 2023

For now this is a draft issue to make a laundry list of CI checks that need to be implemented and modifications to the configuration, build and test system that need to be made to support those checks.

  • In the top CMakeLists.txt file:

    # Including clang-format cmake files to do automatic checking of formating
    include(./cmake/clang-format)

    Use absolute path to clang-format.

  • Use target-based includes in CMake configuration.

  • Review (and if needed modify) build scripts for test architectures (see Sync main with develop #4 for details).

  • Document HyKKT required code style (update CONTRIBUTING.md).

  • Enable linting.

@pelesh
Copy link
Collaborator Author

pelesh commented Mar 31, 2023

CC @cameronrutherford @shakedregev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

2 participants