Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Use Ubuntu 24.04 runners in CI #3794

Open
echoix opened this issue Jun 11, 2024 · 6 comments
Open

[Feat] Use Ubuntu 24.04 runners in CI #3794

echoix opened this issue Jun 11, 2024 · 6 comments
Assignees
Labels
CI Continuous integration enhancement New feature or request linux Linux specific
Milestone

Comments

@echoix
Copy link
Member

echoix commented Jun 11, 2024

Is your feature request related to a problem? Please describe.
For 8.5.0, we should prepare to use the Ubuntu 24.04 runners in CI. A little less software is installed by default, they reduced the default enabled repositories, so we would need to make sure the list of software to install is up to date. Maybe we would have some issues with some extra software not available as is, so maybe we would need to check if the ubuntugis ppa fits our needs (and we could see if the builds work with newest and latest of dependencies).

@echoix echoix added CI Continuous integration enhancement New feature or request linux Linux specific labels Jun 11, 2024
@echoix echoix added this to the 8.5.0 milestone Jun 11, 2024
@echoix echoix self-assigned this Jun 11, 2024
@echoix
Copy link
Member Author

echoix commented Sep 22, 2024

I just saw the announcement posted 5 days ago in actions/runner-images: Ubuntu-latest workflows will use Ubuntu-24.04 image

Starting from September 23, 2024 and expect to be completed October 30th, 2024.

We have some jobs using ubuntu-latest:
image

@wenzeslaus
Copy link
Member

Do you have an idea how to test the ubuntu-latest workflows with new version besides switching them to a specific version? Is that want we want? Seems more straightforward for transitions.

@echoix
Copy link
Member Author

echoix commented Sep 23, 2024

Do you have an idea how to test the ubuntu-latest workflows with new version besides switching them to a specific version? Is that want we want? Seems more straightforward for transitions.

  • Clang format:
    • runs a docker action, so doesn't matter there,
    • plus the create upload suggestion (ours) that is some bash lines (so doesn't matter)
    • upload artifact (node) (so doesn't matter)
  • Create release draft:
    • uses Python, and correctly uses setup-Python (we might want to upgrade it)
    • Might need to check if ./utils/generate_version_git_file.sh assumes that some tools that were available are still available
    • softprops/action-gh-release is a node action, so doesn't matter
  • Docker:
    • the build push actions and all others should be working fine.
  • Labeler: is a node action, so doesn't matter
  • periodic update:
    • checkout: node action, doesn't matter
    • git: still there
    • wget: should still be there
    • peter-evans/create-pull-request: node action, doesn't matter
  • Post pr reviews:
    • download artifact: node action
    • reviewdog/action-setup + installed reviewdog: reviewdog is in go. Should be statically compiled, shouldn't be having problems. Unknown, but surprising if it doesn't work.
    • bash code: doesn't really matter
  • super linter:
    • checkout: node action
    • super-linter: is a docker action, so it will just run the container
  • titles:
    • checkout: node action, doesn't matter
    • we run a python script without installing a python version with setup-Python: if ever our code doesn't work anymore with the future Python versions, we should install a specific one (taking more time). We will get the latest of 3.12.
  • Verify success:
    • bash only logic

@wenzeslaus
Copy link
Member

So that looks like we are in good shape, right?

@echoix
Copy link
Member Author

echoix commented Sep 25, 2024

Yep. The more touchy ones are specified as 22.04. We should still be preparing our build scripts/dependency lists for 24.04. No one had time since June to do it yet.

@thura784
Copy link

thura784 commented Dec 3, 2024

src/features/marketplace/components/TradeableList.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration enhancement New feature or request linux Linux specific
Projects
None yet
Development

No branches or pull requests

3 participants