Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return HTTP 404 for Variable DELETEs When Not Found #63

Open
jbristowe opened this issue Apr 22, 2021 · 0 comments
Open

Return HTTP 404 for Variable DELETEs When Not Found #63

jbristowe opened this issue Apr 22, 2021 · 0 comments
Assignees
@jbristowe
Labels
kind/bug Something isn't working

Comments

@jbristowe
Copy link
Contributor

The VariableService returns a generic error when performing a DELETE command against the underlying endpoint. Behind the scenes, these variables are stored in a VariableSet, which is never deleted -- but that's for another time. ;)

This issue requests correcting the behaviour associated with DELETEs for a variable if it's not found.

Related: #181
@jbristowe jbristowe added the kind/bug Something isn't working label Apr 22, 2021
@jbristowe jbristowe self-assigned this Apr 22, 2021
jbristowe added a commit that referenced this issue Apr 22, 2021
@jbristowe
fix: implementation for variable service to return 404s (#63)
00c79fd
jbristowe added a commit that referenced this issue Apr 22, 2021
@jbristowe
Merge pull request #64 from OctopusDeploy/fix-http-404-variables
fa3f62b 
fix: implementation for variable service to return 404s (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbristowe jbristowe

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbristowe