Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String/Symbol consistency #13

Open
saty9 opened this issue Feb 29, 2024 · 2 comments
Open

String/Symbol consistency #13

saty9 opened this issue Feb 29, 2024 · 2 comments

Comments

@saty9
Copy link

saty9 commented Feb 29, 2024

Currently Enums use strings both for unit enums and newtype enums but structs use symbols this leads to odd looking ruby hashes with mixes of hash rocket and symbol syntax.

Could everything use either strings or symbols. My personal preference is symbols as I think the notation is cleaner. Alternatively could the behaviour be changed using features.

Happy to do the work for this and submit a PR but would like to know there is appetite for this before getting started.

@saty9
Copy link
Author

saty9 commented Feb 29, 2024

Apologies for spam I'm on a train and went through a dead patch and got a little refresh button happy

@ianmurrays
Copy link

I'm also interested in this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants