Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction between revisions and requests #450

Open
baszoetekouw opened this issue Nov 8, 2024 · 2 comments
Open

Interaction between revisions and requests #450

baszoetekouw opened this issue Nov 8, 2024 · 2 comments

Comments

@baszoetekouw
Copy link
Member

baszoetekouw commented Nov 8, 2024

Currently, if a change-request is made (from SP-dashoard), and it is approved, the revision status in Manage will show that the approver has made changes, en the approved request is removed.

So the information of who requested the original changes, and what changes were made by the approver (if any?) are lost.

Can we think of a better way to administer this, so that the revision reflects that this was a one-on-one approval of a request?

@oharsta
Copy link
Member

oharsta commented Nov 15, 2024

We can introduce versioning on change requests by introducing a change_request_revisions collection in Mongo and not delete approved change_requests, but archive them with a reference to the metadata revision that was created by the change request. In the GUI we can show the change requests alongside the revisions. Maximum traceability🕵🏼

@baszoetekouw
Copy link
Member Author

Maybe we should that by simply adding some dashboard-metadata in the revision; maybe start with the request dat and the request user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

2 participants