Enhance RA SS and MW test coverage

[phavekes]

This issue is imported from pivotal - Originaly created at Mar 4, 2020 by bstrooband

This was raised during review of a RA bugfix where the behaviour of the token export button was not tested in RA, but in the behat tests in deploy. The lack of unit and integration tests in the applications is somewhat concerning and should be addressed.

And again during fixing a second bug in RA

What types of tests should be considered?

• Repository tests in Middleware (projectors)
• Decoupled acceptance tests of RA and SS?
• Unit tests for RA, SS, GW covering any important business logic
• Validate and optimize the FGA use cases from the RFC

[phavekes]

Only a few unit tests are added to RA and SA so this should be optimized as this would prevent regressions when adding new functionality.

Also MW repository tests should be added to see if the projections are as expected. (bstrooband - Mar 4, 2020)

[phavekes]

See also the discussion on: OpenConext/Stepup-Middleware#298 (bstrooband - Mar 9, 2020)

[phavekes]

I think, reorganizing the projects into layers would do some good for tests. We are forced to organize existing code into a more structured system. Some refactoring might result from this, making the code more robust, maintainable and most importantly, testable.

If that is impossible, I feel strongly we should cover all services with unit tests. Efforts to decrease coupling seems a good idea at that point.

Needless to say, other important domain and application logic should be reviewed for ample test coverage. Adding involved functional (web/Panther/behat) tests for the individual applications would be a nice bonus.

But opposed to you, I think we should use the deploy behat test suite for that. As you can verify behavior in that environment for all applications. (Michiel Kodde - Mar 10, 2020)