Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controlled list of "external identifers" #155

Open
DsposalTom opened this issue Jul 18, 2024 · 2 comments
Open

Add controlled list of "external identifers" #155

DsposalTom opened this issue Jul 18, 2024 · 2 comments
Assignees
@DsposalTom
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Version 3.0

Comments

@DsposalTom
Copy link
Collaborator

Should we think about adding a controlled list of the externals identifiers.

I am thinking that using a subset of schema.org's product schema? Obvs we don't need it all but it might be worth a conversation.
@DsposalTom DsposalTom added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 18, 2024
@DsposalTom DsposalTom self-assigned this Jul 18, 2024
@DsposalTom DsposalTom moved this to Backlog in Open 3P Aug 2, 2024
@DsposalTom
Copy link
Collaborator Author

I think this would be a minor change and not a patch - moving to Version 3.0 milestone.

@DsposalTom
Copy link
Collaborator Author

These are some examples I found in Schema.org product.

I think we should also include

  • primaryKey

@DsposalTom DsposalTom moved this from Backlog to Ready in Open 3P Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DsposalTom DsposalTom

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Open 3P
Status: Ready
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@DsposalTom