Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp_list.txt does not work when JPEG file names have spaces #1575

Closed
alanterra opened this issue Dec 24, 2022 · 2 comments
Closed

gcp_list.txt does not work when JPEG file names have spaces #1575

alanterra opened this issue Dec 24, 2022 · 2 comments

Comments

@alanterra
Copy link

How did you install ODM? (Docker, installer, natively, ...)?

Docker Desktop downloaded and drag-installed, and WebODM cloned from github on 2022-12-22 onto macOS Intel running Ventura 13.0.1.

What is the problem?

WebODM does not work when you use gcp_list.txt and when there is a space in the names of the JPEG files.

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

I generate the gcp_list.txt using GCP Editor Pro.app. I was able to stitch my files (e.g., into an orthophoto) as long as I did not include GCPs. But when I included GCPs I got the error "Cannot process dataset" about 1 minute into the task.

I got the same error processing locally and on WebODM Lightning.

I was able to fix this error by renaming all my JPEGs to eliminate space characters, changing, e.g., 2022-09-26 15-24-47 DJI_0293.JPG to 2022-09-26_15-24-47_DJI_0293.JPG, and making the same change in gcp_list.txt.

I did not look at the code, but it seems likely that the code for parsing gcp_list.txt uses both spaces and tabs as column delimiters. Since GCP Editor Pro.app only outputs the file with tabs as a delimiter, I suggest that it is not a good idea to use spaces when parsing this file.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

The task settings are:

image

The files are at https://www.dropbox.com/sh/h1xfba79hby7e3k/AAD0oDF8CEnYh4AvLs_tUS-la?dl=0

@pierotofy
Copy link
Member

This probably needs to be fixed in GCP Editor, as spaces are not allowed in the GCP file format spec.

@pierotofy
Copy link
Member

Moving to uav4geo/GCPEditorPro#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants