-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase_info checks and documentation #159
Comments
For Reserve Phases, or phases with Items like
|
Additionally, tests in the examples folder will need to be revised once this work is completed to remove the extra inputs: assuming that all of those make it into the final release. |
Recent experiences with new users modifying phase_info revealed a lack of documentation for how the current functions really work. initial_bounds - the is the absolute start time of the phase, this is in absolute time. unclear on what "input_initial" means automatic calculations that should be happening: for your first phase, if you include takeoff phase, then you need fixed_initial = false, input initial=true, and this should be calculated automatically |
Currently, modifying the Many of the descriptions of the elements within phase_info are inaccurate and inconsistent.
A re-write of phase-info elements requires a return to the fundamental attributes of a states and controls
There are other elements of the phase info that deal with selectively instantiating subsystems ie. aerodynamics, controls, solvers, and anything else that must be created in a phse-specific manner i.e. happens during one part of the mission but no where else. |
Some checks on phase_info exist in methods_for_level2 and some exist in check_phase_info, these should be consolidated to all exist in check_phase_info. |
pre and post mission are not being checked for valid keys. This has caused incorrect keys like |
|
Desired capability or behavior.
Currently
check_phase_info
has some checks for keys, usually that they are required. But we need to more formally define which keys are required or optional and check for them accordingly. We also want to have a warning or error if a user introduces a key that is not recognized or used by Aviary.Is your feature request related to a problem? Please describe.
No response
Associated Bug Report
No response
The text was updated successfully, but these errors were encountered: