Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinGW buildbot: -O2 and "no -O2" needed #80

Open
cron2 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #81
Open

MinGW buildbot: -O2 and "no -O2" needed #80

cron2 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #81
Assignees
@flichtenheld
Labels
enhancement New feature or request

Comments

@cron2
Copy link

cron2 commented Dec 20, 2024

During work on openvpn#836 it was found that the mingw buildbot compiles with -O2 (as it should) and the GHA mingw/cmake build seems to not use -O2, which makes a notable difference for static inline foo() vs. non-static inline foo() definitions - the latter fail to link (not inlined, and not instantiated) when compiling without optimization.

Can we add a mingw build with no -O2 for that? Or any other good suggestion how to catch such omissions?
@flichtenheld flichtenheld transferred this issue from OpenVPN/openvpn-build Dec 27, 2024
@flichtenheld flichtenheld added the enhancement New feature or request label Dec 27, 2024
@flichtenheld flichtenheld changed the title -O2 and "no -O2" needed MinGW buildbot: -O2 and "no -O2" needed Dec 27, 2024
@flichtenheld flichtenheld linked a pull request Dec 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flichtenheld flichtenheld

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MinGW: Build both Release and Debug build types flichtenheld/openvpn-buildbot
3 participants
@flichtenheld @uddr @cron2